feat: make setAuthorizer public for super-callable overrides#307
Conversation
External setAuthorizer was overridable but downstream overrides could only re-implement it; Solidity rejects `super.fn()` on external functions. Public exposes the same ABI (external callers still hit it unchanged) while letting downstream extensions wrap and forward via `super.setAuthorizer(...)` instead of re-implementing the body or calling `_setAuthorizer` directly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe PR changes the ChangessetAuthorizer Visibility Update
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly Related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
external setAuthorizer is overridable but downstream can only re-implement it — Solidity rejects
super.fn()on external functions. public keeps the ABI unchanged for external callers while letting downstream extensions wrap and forward viasuper.setAuthorizer(...).Summary by CodeRabbit