fix: surface oracle reverts from ERC20PriceOracleReceiptVault._nextId

[thedavidmeister]

Summary

• Drop the bare try/catch around priceOracle.price() in _nextId. The catch returned 0, collapsing every oracle error into a downstream Panic(0x12) from divide-by-zero in _calculateMint/_calculateDeposit, erasing the actual selector (e.g. Pyth StalePrice()).
• ERC4626's "MUST NOT revert" surface (max*) is unaffected — those functions don't route through _nextId. mint/deposit may revert, and previewMint/previewDeposit may revert "due to other conditions that would also cause deposit/mint to revert" per spec; a reverting oracle qualifies.
• Independent of this PR, the max* surface has its own MUST-NOT-revert gap (maxWithdraw(owner, 0) panics) tracked in Add ERC4626 spec compliance test suite #303.

Closes #299

Test plan

• New fuzz tests assert the oracle's custom selector propagates through mint, deposit, previewMint, previewDeposit.
• TDD-verified: tests fail against unfixed code with Panic(0x12) / ZeroSharesAmount(); pass after the fix.
• Full suite green (344/344 non-fork tests pass).
• CI passes

🤖 Generated with Claude Code

[coderabbitai]

Warning

Rate limit exceeded

@thedavidmeister has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 17 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0d82b0cf-14c5-44a8-ae18-7e86b00e3f7d

📥 Commits

Reviewing files that changed from the base of the PR and between 78390b1 and 096b0f4.

📒 Files selected for processing (2)

• src/concrete/vault/ERC20PriceOracleReceiptVault.sol
• test/src/concrete/vault/ERC20PriceOracleReceiptVault.oracleRevert.t.sol

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 2026-05-14-issue-299-oracle-revert-passthrough

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}