Skip to content

fix(soldeer): ignore .envrc and .prettierignore on publish#214

Merged
thedavidmeister merged 2 commits into
mainfrom
2026-05-13-soldeerignore-dotfiles
May 13, 2026
Merged

fix(soldeer): ignore .envrc and .prettierignore on publish#214
thedavidmeister merged 2 commits into
mainfrom
2026-05-13-soldeerignore-dotfiles

Conversation

@thedavidmeister
Copy link
Copy Markdown
Contributor

@thedavidmeister thedavidmeister commented May 13, 2026

Summary

  • Add .envrc and .prettierignore to .soldeerignore.
  • Both are tracked dotfiles that trip soldeer's check_dotfiles warning. CI has no TTY for the confirmation prompt, so soldeer errors with error during IO operation for "": not connected and the publish fails (run 25800427603).

Test plan

  • forge soldeer push rain-math-float~0.1.0 --dry-run locally — zip no longer contains either file.
  • Re-tag v0.1.0 after merge; publish-soldeer.yaml succeeds.

Summary by CodeRabbit

  • Chores
    • Updated package release workflow configuration
    • Refined repository ignore patterns for configuration files

Review Change Stack

thedavidmeister and others added 2 commits May 13, 2026 17:06
The bump step in package-release.yaml runs cargo release without --no-publish, which makes it try to publish to crates.io. CARGO_REGISTRY_TOKEN is only set on the separate Publish to crates.io step further down, so the bump step fails with no token found, please run cargo login.

Add --no-publish so the bump step only bumps the version + commits. The dedicated Publish step does the upload with the token set.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Both tracked, both trip soldeer's check_dotfiles warning. In CI there
is no TTY, so the confirmation prompt fails with "not connected" and
the publish errors out.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@thedavidmeister thedavidmeister self-assigned this May 13, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e7780a9a-7af1-4255-96e0-374d0e67ebe6

📥 Commits

Reviewing files that changed from the base of the PR and between 8b9c65d and 39663cc.

📒 Files selected for processing (2)
  • .github/workflows/package-release.yaml
  • .soldeerignore

Walkthrough

CI workflow and ignore patterns updated: cargo release command flags modified to remove --no-push and add --no-publish; .soldeerignore extended with .envrc and .prettierignore patterns.

Changes

Configuration Updates

Layer / File(s) Summary
Cargo release command flags
.github/workflows/package-release.yaml
Cargo release invocation modified to remove --no-push and add --no-publish, changing commit/tag push and publish behavior in the package release workflow.
Soldeer ignore patterns
.soldeerignore
Ignore patterns extended with .envrc and .prettierignore entries alongside existing dotfile and project path ignores.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding .envrc and .prettierignore to .soldeerignore for publish. However, it does not reflect the secondary but significant change to the CI workflow (cargo release --no-publish flag).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-05-13-soldeerignore-dotfiles

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thedavidmeister thedavidmeister merged commit 56af232 into main May 13, 2026
9 of 10 checks passed
@github-actions
Copy link
Copy Markdown

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

  • Simple bug fixes, typos, or minor refactoring
  • Single-purpose changes affecting 1-2 files
  • Documentation updates
  • Configuration tweaks
  • Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

  • Fix typo in variable name
  • Update README with new instructions
  • Adjust configuration values
  • Simple one-line bug fixes
  • Import statement cleanup

Medium (M)

Characteristics:

  • Feature additions or enhancements
  • Refactoring that touches multiple files but maintains existing behavior
  • Breaking changes with backward compatibility
  • Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

  • Add new feature or component
  • Refactor common utility functions
  • Update dependencies with minor breaking changes
  • Add new component with tests
  • Performance optimizations
  • More complex bug fixes

Large (L)

Characteristics:

  • Major feature implementations
  • Breaking changes or API redesigns
  • Complex refactoring across multiple modules
  • New architectural patterns or significant design changes
  • Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

  • Complete new feature with frontend/backend changes
  • Protocol upgrades or breaking changes
  • Major architectural refactoring
  • Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

  • Test coverage impact: More comprehensive test changes lean toward larger classification
  • Risk level: Changes to critical systems bump up a size category
  • Team familiarity: Novel patterns or technologies increase complexity

Notes:

  • the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
  • the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
  • do not include any additional text, only the size classification
  • your assessment comment must not include tips or additional sections
  • do NOT tag me or anyone else on your comment

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

Tip

For best results, initiate chat on the files or code changes.

SIZE=S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant