refactor: use relative paths for vendored Flare imports#35
Merged
Conversation
Drop the flare-smart-contracts/ and flare-smart-contracts-v2/ remappings; rewrite the source imports that used them to relative paths into src/vendor/. Downstream soldeer consumers no longer need a bridge remapping to pull these interfaces transitively. Closes #34. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (8)
WalkthroughThis PR systematically converts all imports of vendored Flare interfaces from package-style paths (resolved via foundry.toml remappings) to direct relative paths. The foundry.toml remappings are removed, and all source and test files update their imports to reference ChangesImport Path Refactoring
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flare-smart-contracts/=src/vendor/...andflare-smart-contracts-v2/=...remappings fromfoundry.toml.src/vendor/../src/...ordependencies/rain-flare-X.Y.Z/src/....Closes #34.
🤖 Generated with Claude Code
Summary by CodeRabbit