Skip to content

Eagerly initialize last_id to avoid skipping messages #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
npezza93 merged 2 commits into from
Mar 17, 2026
Merged

Eagerly initialize last_id to avoid skipping messages #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c07803
Eagerly initialize last_id to avoid missed messages
xrav3nz Mar 4, 2026
40a9289
Remove redundant test
xrav3nz Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions lib/action_cable/subscription_adapter/solid_cable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ def initialize(event_loop)
@critical = Concurrent::Semaphore.new(0)

@reconnect_attempt = 0
@last_id = last_message_id

@thread = Thread.new do
Thread.current.name = "solid_cable_listener"
Expand Down Expand Up @@ -113,12 +114,7 @@ def invoke_callback(*)

private
attr_reader :event_loop, :thread
attr_writer :last_id
attr_accessor :reconnect_attempt

def last_id
@last_id ||= last_message_id
end
attr_accessor :last_id, :reconnect_attempt

def last_message_id
::SolidCable::Message.maximum(:id) || 0
Expand Down
1 change: 0 additions & 1 deletion test/lib/action_cable/subscription_adapter/solid_cable_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,6 @@ def subscribe_as_queue(channel, adapter = @rx_adapter)
subscribed = Concurrent::Event.new
adapter.subscribe(channel, callback, proc { subscribed.set })
subscribed.wait(WAIT_WHEN_EXPECTING_EVENT)
sleep WAIT_WHEN_EXPECTING_EVENT
assert_predicate subscribed, :set?

yield queue
Expand Down