build: set cmake_minimum_required to 3.10#18
Merged
jmberg merged 1 commit intoradiotap:masterfrom Mar 26, 2026
Merged
Conversation
New cmake versions require at least 3.5 as 'cmake_minimum_required' in CMakeLists.txt. In future 3.10 will be required. Signed-off-by: Nick Hainke <vincent@systemli.org>
Contributor
|
Not sure I understand why it would be that "[i]n [the] future 3.10 will be required"? Especially since you're not making any other changes. Please clarify the commit message. |
Contributor
|
@jmberg future version of cmake will require 3.10 version. |
Contributor
Author
|
OpenWrt switched to cmake 4.x so currently the lib does not build (however, we added this PR as patch) |
Contributor
|
@jmberg any news for this and the other pr? |
Contributor
|
Well, I do think the commit message should be clarified... |
Contributor
|
Sure but again it's really to follow required changes for cmake, nothing
fancy
Il Mar 25 Nov 2025, 08:27 jmberg ***@***.***> ha scritto:
… *jmberg* left a comment (radiotap/radiotap-library#18)
<#18 (comment)>
Well, I do think the commit message should be clarified...
—
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE2ZMQXYVNKUCTK3KWCIPHL36QAG7AVCNFSM6AAAAACLSXHDHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKNZUGEYDIMRRHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Contributor
|
Nobody cared enough to fix the commit message. |
Contributor
|
Can I send and fix the message?
Il Gio 26 Mar 2026, 10:55 jmberg ***@***.***> ha scritto:
… *jmberg* left a comment (radiotap/radiotap-library#18)
<#18?email_source=notifications&email_token=AE2ZMQWPKLBW2FRKEF3YPK34ST5ADA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJTGMZDAMRTGEYKM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4133202310>
Nobody cared enough to fix the commit message.
—
Reply to this email directly, view it on GitHub
<#18?email_source=notifications&email_token=AE2ZMQWPKLBW2FRKEF3YPK34ST5ADA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJTGMZDAMRTGEYKM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4133202310>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE2ZMQQU7FBU3TJANEQ2KBD4ST5ADAVCNFSM6AAAAACLSXHDHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCMZTGIYDEMZRGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Contributor
|
maybe it doesn't matter ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New cmake versions require at least 3.5 as 'cmake_minimum_required' in CMakeLists.txt. In future 3.10 will be required.