chore(ci): Configure eslint in CI #9
Draft
+47
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairmare
force-pushed
the
chore/eslint-configuration
branch
from
5b88139 to
650fbc6
Compare
hairmare
force-pushed
the
chore/eslint-configuration
branch
from
650fbc6 to
4e96a3f
Compare
hairmare
force-pushed
the
chore/eslint-configuration
branch
from
4e96a3f to
c182716
Compare
hairmare
force-pushed
the
chore/eslint-configuration
branch
from
c182716 to
54fddb3
Compare
hairmare
force-pushed
the
chore/eslint-configuration
branch
from
54fddb3 to
afcb647
Compare
hairmare
force-pushed
the
chore/eslint-configuration
branch
from
afcb647 to
41bf8d0
Compare
hairmare
force-pushed
the
chore/eslint-configuration
branch
3 times, most recently
from
edce36c to
4df5372
Compare
hairmare
force-pushed
the
chore/eslint-configuration
branch
from
4df5372 to
de2a98b
Compare
hairmare
force-pushed
the
chore/eslint-configuration
branch
from
de2a98b to
7c85f50
Compare
Member
Author
|
The linter is currently failing (and need fixing before this makes sense): $ /home/runner/work/website-stack/website-stack/next/node_modules/.bin/next lint --output-file ../next-eslint_report.json --format json
Converting circular structure to JSON
--> starting at object with constructor 'Object'
| property 'configs' -> object with constructor 'Object'
| property 'flat' -> object with constructor 'Object'
| ...
| property 'plugins' -> object with constructor 'Object'
--- property 'react' closes the circle
Referenced from: /home/runner/work/website-stack/website-stack/next/.eslintrc.json |
hairmare
force-pushed
the
chore/eslint-configuration
branch
from
7c85f50 to
fc001c5
Compare
* Run `next lint` on pull requests
hairmare
force-pushed
the
chore/eslint-configuration
branch
from
fc001c5 to
1e0cda5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure eslint to run against the code. Based on the Next.JS reference configuration.
eslintdoes static testing, it's raison d'être is to ensure that the quality of code matches what can be reasonably expected from a modern next application. This improves the security, readability, and maintainability of the code.Since the
next/folder was initialized with typescript support, we configure eslint for typescript.note: A high amount of eslint complaints is expected when initially adopting eslint. Most likely they consist of a ton of low hanging fruit that can be easily auto-fixed.