WIP: Sanitize debugger argv to prevent r2 command injection#13
Open
WIP: Sanitize debugger argv to prevent r2 command injection#13
Conversation
Contributor
Author
|
Codex did a pretty bad job here, because the right fix would be to use the single quote or do the |
6f917ba to
18587bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
init_debugpath previously concatenated unescapedargvinto an r2doocommand, allowing;or shell escapes in user-supplied args to inject extra r2 commands and enabling an RCE vector.Description
escape_debug_argandescape_debug_argshelper functions to quote each argument and escape embedded quotes, backslashes, newlines, and carriage returns.escape_debug_argsinR2Api::init_debuginstead ofargs.join(" ")so the constructeddoocommand uses quoted, escaped arguments.#[cfg(test)]that assert argument quoting and escaping behavior for spaces and special characters.Testing
cargo test -p radius2 --lib, which could not complete in this environment because theboolector-sysvendored build attempted to download lingeling and failed withcurl: (56) CONNECT tunnel failed, response 403. (test run failed)cargo test -p radius2 --lib --no-default-features, which failed at link time due to missing-lboolectorin this environment (linker error). (test run failed)Codex Task