(WIP) Use define-deprecated-alias for legacy aliases#1460
Draft
jackfirth wants to merge 9 commits intoracket:masterfrom
Draft
(WIP) Use define-deprecated-alias for legacy aliases#1460jackfirth wants to merge 9 commits intoracket:masterfrom
define-deprecated-alias for legacy aliases#1460jackfirth wants to merge 9 commits intoracket:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Resyntax analyzed 2 files in this pull request and has added suggestions.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Resyntax analyzed 2 files in this pull request and found no issues.
There was a problem hiding this comment.
Resyntax analyzed 2 files in this pull request and found no issues.
Contributor
Author
|
@samth These test failures confound me. Any idea what's going on here? |
Member
|
That's some of the most fragile code in TR. Is that test using the old alias or the new name? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a (very) work-in-progress pull request to use the new
define-deprecated-aliasform to define the various aliases listed in Legacy Forms. This will allow Resyntax to automatically migrate users of these forms to their recommended replacements.