Closed
Conversation
Use `make-temporary-directory` to make directories instead of `make-temporary-file`.
Nested `when` expressions can be merged into a single compound `when` expression.
This quasiquotation is equialent to a simple `list` call.
This `begin` form can be flattened into the surrounding definition context.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `map` operation can be replaced with a `for/list` loop.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Use `raise-arguments-error` instead of `error` for better error messages that follow Racket conventions.
This `string-append` with `format` expression can be simplified to a single `format` call.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `map` operation can be replaced with a `for/list` loop.
rfindler
reviewed
Oct 27, 2025
| (append (sort (send item get-shortcut-prefix) string<=? #:key symbol->string) | ||
| (list (send item get-shortcut)))) | ||
| (hash-update! shortcuts k (λ (v) (cons (send item get-label) v)) '()))) | ||
|
|
Member
There was a problem hiding this comment.
I'm not digging this change; the and seems harder to read, as does new set of line breaks.
Collaborator
There was a problem hiding this comment.
The line breaks are fmt's doing. As for the when merging, I think I'll try adjusting that rule to only fire if there's three or more nested when forms. That seems more likely to be an improvement when it applies.
Collaborator
There was a problem hiding this comment.
I've filed jackfirth/resyntax#639 to address this.
rfindler
reviewed
Oct 27, 2025
| (k gui-thing)])))])) | ||
| (error 'find-output-radio-box "could not find `~a' radio box" | ||
| label))) | ||
| (raise-arguments-error 'find-output-radio-box "could not find `' radio box" "label" label))) |
Member
There was a problem hiding this comment.
I think this change is incorrect.
Member
There was a problem hiding this comment.
Oh, I see that you have already done something about this, @jackfirth . But also, this isn't a problem with the arguments of the function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 19 issues in 7 files.
let-to-definequasiquote-to-listmap-to-forcond-let-to-cond-definestring-append-with-format-to-formatmake-temporary-directory-migrationnested-when-to-compound-wheninline-unnecessary-beginerror-to-raise-arguments-error