Closed
Conversation
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `for-each` operation can be replaced with a `for` loop.
Nested `when` expressions can be merged into a single compound `when` expression.
This `string-append` with `format` expression can be simplified to a single `format` call.
The `instantiate` form is for mixing positional and by-name constructor arguments. When no positional arguments are needed, use `new` instead.
The `instantiate` form is for mixing positional and by-name constructor arguments. When no by-name arguments are needed, use `make-object` instead.
Using `cond` instead of `if` here makes `begin` unnecessary
Member
|
I'm not a fan of the change in "Fix 1 occurrence of string-append-with-format-to-format" here. |
Member
|
I cherry picked the rest of the commits, so I'll close this PR. |
Collaborator
|
Oof yeah that one definitely isn't ideal. I'll try to make some improvements there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 6 files.
instantiate-to-newlet-to-defineinstantiate-to-make-objectif-begin-to-condstring-append-with-format-to-formatnested-when-to-compound-whenfor-each-to-for