Conversation
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `map` operation can be replaced with a `for/list` loop.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This expression can be replaced with a simpler, equivalent `hash-update!` expression.
This `in-hash` can be replaced with `in-hash-keys` since the value is not used.
This `if` expression can be refactored to an equivalent expression using `and`.
This `in-hash` can be replaced with `in-hash-values` since the key is not used.
Add an explicit `[else (void)]` clause to make the default behavior clear.
The `apply` function accepts single arguments in addition to a trailing list argument.
This `string-append` with `format` expression can be simplified to a single `format` call.
The result of this `map` expression is unused. Make that explicit with `for-each` instead.
The `instantiate` form is for mixing positional and by-name constructor arguments. When no positional arguments are needed, use `new` instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 3 files.
let-to-definein-hash-to-in-hash-keysignored-map-to-for-eachin-hash-to-in-hash-valuesinstantiate-to-newcond-let-to-cond-defineif-else-false-to-andstring-append-with-format-to-formathash-set!-ref-to-hash-update!explicit-cond-else-voidmap-to-forapply-flattening