Skip to content

fix: update BMC code to set correct pxe interface. #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cardoe merged 2 commits into from
Jan 23, 2026
Merged

fix: update BMC code to set correct pxe interface. #1627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82b3263
fix: update BMC code fto set correct pxe interface.
RSabounds Jan 23, 2026
8d0df54
raise switch_enabled resource results.
RSabounds Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/understack-workflows/understack_workflows/bmc_bios.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def required_bios_settings(pxe_interface: str) -> dict:
}


def update_dell_bios_settings(bmc: Bmc, pxe_interface="NIC.Integrated.1-1") -> dict:
def update_dell_bios_settings(bmc: Bmc, pxe_interface: str) -> dict:
"""Check and update BIOS settings to standard as required.

Any changes take effect on next server reboot.
Expand Down
17 changes: 16 additions & 1 deletion python/understack-workflows/understack_workflows/main/enroll_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ def _pxe_preference(interface: InterfaceInfo) -> int:
_name = interface.name.upper()
if "DRAC" in _name or "ILO" in _name or "NIC.EMBEDDED" in _name:
return 0
enabled_result = 100 if (interface.remote_switch_port_name is not None) else 0

NIC_PREFERENCE = {
"NIC.Integrated.1-1-1": 100,
Expand All @@ -124,8 +125,22 @@ def _pxe_preference(interface: InterfaceInfo) -> int:
"NIC.Integrated.1-2": 95,
"NIC.Slot.1-2-1": 94,
"NIC.Slot.1-2": 93,
"NIC.Slot.1-3-1": 92,
"NIC.Slot.1-3": 91,
"NIC.Slot.2-1-1": 90,
"NIC.Slot.2-1": 89,
"NIC.Integrated.2-1-1": 88,
"NIC.Integrated.2-1": 87,
"NIC.Slot.2-2-1": 86,
"NIC.Slot.2-2": 85,
"NIC.Integrated.2-2-1": 84,
"NIC.Integrated.2-2": 83,
"NIC.Slot.3-1-1": 82,
"NIC.Slot.3-1": 81,
"NIC.Slot.3-2-1": 80,
"NIC.Slot.3-2": 79,
}
return NIC_PREFERENCE.get(interface.name, 50)
return NIC_PREFERENCE.get(interface.name, 50) + enabled_result


def argument_parser():
Expand Down
Loading