Conversation
AJStieren
left a comment
AJStieren
left a comment
There was a problem hiding this comment.
Some of the configs need to be migrated from the WEB-INF to keep filter functionality. Also advocating to move to log4j2 or at least update log4j.
Install was successful, tests passed, and builds produced the expected artifacts. Good job.
| <groupId>org.springframework</groupId> | ||
| <artifactId>spring-webmvc</artifactId> | ||
| <version>${org.springframework.version}</version> | ||
| <groupId>log4j</groupId> |
There was a problem hiding this comment.
Let's do log4j2. Actually we could probably add an slf4j overlay on the log4j2 as well for future proofing.
nvm, this is scope creep
| @@ -1,67 +0,0 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Dropping this means the much of this configuration needs to be migrated to the spring Boot. The filter mapping we have here is necessary. The logging hooks for Spring Boot should also be instantiated through log4j, though I'm advocating to move to log4j2 in line with Repose.
There was a problem hiding this comment.
Added lo4j2 config with the project.
There was a problem hiding this comment.
Yeah, sorry... this is my bad, but I realized after the fact that moving from log4j to log4j2 is gross scope creep for the story. Move back to log4j and we'll do a logging enhancement story later.
AJStieren
left a comment
AJStieren
left a comment
There was a problem hiding this comment.
Changes look good, rpm builds in a centos container, and tests are passing.
2 participants
This project has been converted to spring boot from spring mvc.
Key factors to keep in mind while testing it..
mvn clean install
for generating the rpm files and testing it
mvn clean install -Pbuild-app-rpm,build-xslt-rpm
Also keep the usage schema version and snapshot version
please also test for plugin of rpm build while testing in pom.xml
5 .Removed WEB-INF folder as not needed in spring boot project