MAINT: Remove multiple aliases from process pools#856
Draft
Conversation
Contributor
|
Is the approach here to basically not worry about destruction of anything until process-end? |
Contributor
Author
|
Yes, but that is more or less the approach that has been taken ever since we stopped using Contexts as Scopes, This PR is primarily trying to rework things such that we don't have unique aliases referring to a given Artifact anymore. Our one alias ought to hang around for the process lifetime now I believe. |
…handling removal of path
Oddant1
added
the
stat:blocking-other
Contributor
Author
|
Blocking qiime2/q2cli#374 |
Contributor
Author
|
It turns out that, unsurprisingly, there isn't a super-easy win to be had here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should no longer be required to create many aliases of the same artifact in process pools now that we no longer enter Contexts as Scopes.
Supercedes #855 with a slightly reworked and better approach.