refactor(pop-cli): route progress UI through cli abstractions#988
Merged
refactor(pop-cli): route progress UI through cli abstractions#988
Conversation
Replace direct cliclack spinners with CLI-provided spinner/multi-progress wrappers, and add output-mode-aware subprocess execution helpers. Relax invalid URI test assertions to accept transport-specific errors across environments.
Collaborator
Author
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Mark spinner and multi-progress helper types as intentionally reusable across feature subsets so cargo check --no-default-features with -Dwarnings succeeds.
Set docker/build-push-action context to the checked-out workspace in PR CI, avoiding authenticated remote Git context fetch failures.
Create reusable composite actions for Rust setup, protobuf install, nextest install, pop binary caching, Docker readiness, and ink-node lifecycle. Adopt these actions across integration, coverage, and release workflows to remove duplicated shell logic and centralize CI behavior.
Local composite actions require the repository to be checked out first. Three integration test jobs referenced .github/actions/free-up-space before actions/checkout, causing immediate failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #970.
Summary
Refactors Pop CLI progress reporting to use CLI-level abstractions, keeping progress output consistent across human and JSON modes.
Hardens CI behavior by fixing Docker build context usage and ensuring Docker availability for Linux integration jobs that run verifiable contract flows.
Reduces workflow duplication by extracting shared routines into reusable composite actions and adopting them across integration, coverage, and release pipelines.