Draft
Conversation
- Parse memory profiling data (small_v, big_v, nodes, dup_count) from Rprof output - Extend sample_types table to include memory sample types - Add memory columns to samples table - Update validate_profile() to support memory profiling data - Update ds_to_rprof / write_rprof for memory profiling roundtrip - Update pprof read/write to handle memory sample types - Add sample memory profiling data file (memory.out) - Add comprehensive tests for memory profiling Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for memory profiling in proffer
Add memory profiling support
Feb 13, 2026
Member
|
@copilot: The columns in the data must remain the same, regardless of the presence of memory profiling data. Use long formats where appropriate, or populate with missing values. |
sample_types always has 5 rows and samples always has 6 columns (value, locations, small_v, big_v, nodes, dup_count). When no memory profiling data is present, memory columns are all NA_integer_. Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Author
Updated in f4636da. The format is now type-stable: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inst/samples/rprof/memory.out)read_rprof_ll()to detect and parse memory profiling header and data prefixrprof_to_ds()to extract memory data from trace linesvalidate_profile()to support memory profiling datads_to_rprof()/write_rprof()for memory profiling roundtripsample_typesalways has 5 rows,samplesalways has 6 columns (memory columns areNAwhen no memory data is present)Original prompt
This section details on the original issue you should resolve
<issue_title>Memory profiling</issue_title>
<issue_description>I received a request to support memory profiling in
proffer(r-prof/proffer#32) and I am trying to figure out whyproffer::pprof(memory.profiling = TRUE)does not show memory profiling in thepprofdashboard. I am wondering ifprofileis already capturing the memory data. I have a small example:It looks like
Rprof()is correctly recording memory data.But I am having trouble locating memory data in the data from
profile::read_rprof(), whichprofferuses to convert topprofformat..