Return partial results in the condition on interrupt#237
Merged
Conversation
Single line # nocov does not work because air puts it on the wrong line.
Member
|
Did you consider just switching to |
Member
Author
|
Yeah, I looked at that solution. But it does not seem like a good idea to me to ignore interrupts and return partial results downstream. I think if the user presses an interrupt in an interactive session or sends a SIGINT to a worker subprocess then they want the computation/worker stopped. This is essentially the same concert you had in the issue, hence your top-level restriction suggestion. I think this PR essentially implements that at the top level and has more predictable behavior, i.e. an interrupt will jump to top level. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #98.