Conversation
|
@malcolmbarrett & @tgerke can you please review this -- I took out the Monte Carlo piece because I don't think we really need it but please let me know if you disagree! |
malcolmbarrett
left a comment
There was a problem hiding this comment.
Thanks for getting this in! I added some requests for other areas of content as well as some stylistic things. I don't focus so much on the latter as I will give this a polish later.
|
I slept on this, and there are a few other things I wanted to include in this chapter:
Also see #240 (comment) re: variance with marginaleffects |
Co-authored-by: Malcolm Barrett <malcolmbarrett@users.noreply.github.com>
Co-authored-by: Malcolm Barrett <malcolmbarrett@users.noreply.github.com>
Co-authored-by: Malcolm Barrett <malcolmbarrett@users.noreply.github.com>
|
@malcolmbarrett @tgerke if y'all want to take another look at this that would be great! (@tgerke if you could please take a closer look at my time varying section to make sure it looks ago that would be awesome). |
|
I'll take a look in the next day or two! the failures on CI should resolve with the new WeightIt release which fixes an error related to a dependency and unrelated to your changes |
No description provided.