Skip to content

G comp chapter#352

Merged
malcolmbarrett merged 19 commits intomainfrom
g-comp
Mar 25, 2026
Merged

G comp chapter#352
malcolmbarrett merged 19 commits intomainfrom
g-comp

Conversation

@LucyMcGowan
Copy link
Copy Markdown
Collaborator

No description provided.

@LucyMcGowan
Copy link
Copy Markdown
Collaborator Author

@malcolmbarrett & @tgerke can you please review this -- I took out the Monte Carlo piece because I don't think we really need it but please let me know if you disagree!

@github-actions github-actions Bot temporarily deployed to pull request November 21, 2025 14:36 Inactive
Copy link
Copy Markdown
Member

@malcolmbarrett malcolmbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this in! I added some requests for other areas of content as well as some stylistic things. I don't focus so much on the latter as I will give this a polish later.

Comment thread chapters/13-g-comp.qmd Outdated
Comment thread chapters/13-g-comp.qmd
Comment thread chapters/13-g-comp.qmd Outdated
Comment thread chapters/13-g-comp.qmd
Comment thread chapters/13-g-comp.qmd
Comment thread chapters/13-g-comp.qmd Outdated
Comment thread chapters/13-g-comp.qmd Outdated
Comment thread chapters/13-g-comp.qmd Outdated
Comment thread chapters/13-g-comp.qmd Outdated
Comment thread chapters/13-g-comp.qmd Outdated
@malcolmbarrett
Copy link
Copy Markdown
Member

I slept on this, and there are a few other things I wanted to include in this chapter:

Also see #240 (comment) re: variance with marginaleffects

LucyMcGowan and others added 3 commits January 16, 2026 13:12
Co-authored-by: Malcolm Barrett <malcolmbarrett@users.noreply.github.com>
Co-authored-by: Malcolm Barrett <malcolmbarrett@users.noreply.github.com>
Co-authored-by: Malcolm Barrett <malcolmbarrett@users.noreply.github.com>
@github-actions github-actions Bot temporarily deployed to pull request January 16, 2026 18:24 Inactive
@LucyMcGowan
Copy link
Copy Markdown
Collaborator Author

@malcolmbarrett @tgerke if y'all want to take another look at this that would be great! (@tgerke if you could please take a closer look at my time varying section to make sure it looks ago that would be awesome).

@malcolmbarrett
Copy link
Copy Markdown
Member

I'll take a look in the next day or two! the failures on CI should resolve with the new WeightIt release which fixes an error related to a dependency and unrelated to your changes

@malcolmbarrett malcolmbarrett self-requested a review March 19, 2026 16:09
@github-actions github-actions Bot temporarily deployed to pull request March 25, 2026 13:39 Inactive
Copy link
Copy Markdown
Member

@malcolmbarrett malcolmbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stellar 🤩

@github-actions github-actions Bot temporarily deployed to pull request March 25, 2026 15:29 Inactive
@malcolmbarrett malcolmbarrett merged commit 256fd6e into main Mar 25, 2026
2 checks passed
@malcolmbarrett malcolmbarrett deleted the g-comp branch March 25, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants