Skip to content

Fix giphy command #1613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkay0670 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix giphy command #1613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c5994f
Fix giphy command
dkay0670 Jun 16, 2026
fae936f
Update changelog
dkay0670 Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ Changes since 2026.06.15

## Fun

### Giphy
- Fixes giphy command not correctly returning the image

## Internal

## Moderation
Expand Down
18 changes: 2 additions & 16 deletions modules/fun/giphy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,22 +41,9 @@ class Giphy(cogs.BaseCog):
SEARCH_LIMIT (int): The max amount of gifs to search for
"""

GIPHY_URL: str = "http://api.giphy.com/v1/gifs/search?q={}&api_key={}&limit={}"
GIPHY_URL: str = "https://api.giphy.com/v1/gifs/search?q={}&api_key={}&limit={}"
SEARCH_LIMIT: int = 10

@staticmethod
def parse_url(url: str) -> str:
"""Parses the raw API url into a useable gif link

Args:
url (str): The raw URL from Giphy

Returns:
str: The direct link to the gif, if it exists
"""
index = url.find("?cid=")
return url[:index]

@auxiliary.with_typing
@commands.guild_only()
@commands.command(
Expand Down Expand Up @@ -90,8 +77,7 @@ async def giphy(self: Self, ctx: commands.Context, *, query: str) -> None:

embeds = []
for item in data:
url = item.get("images", {}).get("original", {}).get("url")
url = self.parse_url(url)
url = item.get("embed_url", {})
embeds.append(url)

await ui.PaginateView().send(ctx.channel, ctx.author, embeds)
Loading