Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the tutorial notebook CI workflows to test against both released and master versions of QuTiP (v4 release, v5 release, v5 master), while only publishing artifacts for released versions to avoid exposing master-branch deprecation warnings.
Changes:
- Expand the test matrix to include
v4-release,v5-release, andv5-masterwith separate install specs. - Switch QuTiP/QIP installation to use pip specs (PyPI releases or git refs) while still sourcing dependency requirements from a checked-out QuTiP branch.
- Update artifact naming and (for
notebook_ci.yaml) publish step to download only the released artifacts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
.github/workflows/notebook_ci.yaml |
Adds 3-way matrix (v4 release, v5 release, v5 master), changes install strategy, and publishes only released artifacts. |
.github/workflows/nightly_ci.yaml |
Mirrors the 3-way matrix and install strategy changes for scheduled nightly runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@BoxiLi This looks like a good idea to me. Once tests pass here we could merge and then check that the publishing works correctly. |
Member
Author
|
Looks like when I remove the package installation from requirement.txt, the test breaks, because Cython is not installed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test for v4-release, v5-release and v5-master. Publish only the two released versions.
In this way, people will not see deprecation warnings in the unreleased master branch. But all notebooks should pass for both released and master versions
The downside is that we add one more test branch.