Open
Conversation
Member
|
@nwlambert please look at this :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the previous PR #74 . The function to get the spectral density of the system is specific to CSR I guess eventually, one would want functions in https://qutip.readthedocs.io/en/latest/guide/guide-correlation.html to work with HEOM as well. I can try to put up a PR for that next week 😃
I also left approximate, but currently, one should use approx_by_pade. This weekend I'll put up a PR to have the same functionality of BosonicEnvironments into FermionicEnvironments (user-defined and fitting), so it can be left with approximate till then.
If not then change to approx_by_pade, and then we'll update this later when the PR with the fermionic stuff gets merged.