test: Phase 4 - Feature module tests (154 new tests)#3542
Merged
ahmedre merged 3 commits intoquran:mainfrom Mar 29, 2026
Merged
test: Phase 4 - Feature module tests (154 new tests)#3542ahmedre merged 3 commits intoquran:mainfrom
ahmedre merged 3 commits intoquran:mainfrom
Conversation
7f93839 to
e4b0b59
Compare
3af5e54 to
3e0716a
Compare
- ArabicSearcherTest: extract realArabicSearcher to setUp, remove inline construction - LineCalculationTest: fix weak assertion isAtLeast(-1) to isAnyOf(-1, 1) - QariListPresenterTest: remove unused name parameter from helper functions - FakeHashCalculator: remove unused shouldThrow dead code - FakeSettings: add missing setPageType from upstream interface change - common:search build.gradle: document why returnDefaultValues is needed
3e0716a to
db83570
Compare
- Fix multi-collector test in AudioBarEventRepositoryTest to use concurrent launch instead of nested sequential test blocks - Refactor QuranLineByLineSettingsPresenter to accept injectable CoroutineScope, eliminating runBlocking + Dispatchers.IO racy tests - Migrate all LineByLine settings tests from runBlocking to runTest - Remove replay=1 from FakeSettings.preferencesSharedFlow - Fix LineCalculationTest: correct middle-of-page y value, add meaningful resizeLinesToFit assertion, fix isAnyOf(-1,1) to isEqualTo(-1) - Remove tautological data-class test in PartiallyDownloadedSuraExtensionTest, replace with gap-detection test - Strengthen DefaultSearcherTest LIMIT assertion to isEqualTo - Add gapped section ordering test in QariListPresenterTest - Fix misleading comment about deduplication in QariListPresenterTest - Add selectionStart=endAyah edge case in AyahSelectionExtensionTest - Fix comment typo in SelectionHelperTest (0.1 → 0.09f) - Add StateFlow rationale comment in FakeQariDownloadInfoSource - Expose FakeSearcher.queryResponse to remove magic string assertion
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 4: Feature module tests. Adds 154 new unit tests across 6 modules.
Builds on Phase 3 (#3539).
New Tests
Production Changes
One minimal interface extraction:
QariDownloadInfoSourceinterface added tocommon:audioQariDownloadInfoManagerimplements itQariListPresenterconstructor param changed to interfaceApplicationModuleNew Fakes
FakeSettings— implementscom.quran.data.dao.SettingsFakeQariDownloadInfoSource— MutableStateFlow-backedFakeHashCalculator— deterministic hash for AudioFileCheckerImpl testsTest Plan
./gradlew :app:testMadaniDebugUnitTest— regression check pass