Skip to content

Fix tests #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
osamasayed merged 2 commits into from
Jan 19, 2026
Merged

Fix tests #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69f8665
Fix tests
osamasayed Jan 19, 2026
cdcc142
update README
osamasayed Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ you can visit the [docs][docs] for more details.

<!-- Links -->

[qdc-api]: https://api-docs.quran.com/docs/category/content-apis
[docs]: https://quranjs.com/
[qdc-api]: https://api-docs.quran.foundation/docs/category/content-apis
[docs]: https://api-docs.quran.foundation/docs/sdk/javascript
[build-badge]: https://github.com/quran/api-js/workflows/CI/badge.svg
[build]: https://github.com/quran/api-js/actions?query=workflow%3ACI
[license-badge]: https://badgen.net/github/license/quranjs/api
Expand Down
50 changes: 25 additions & 25 deletions packages/api/test/search.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { describe, expect, it } from "vitest";
import { http, HttpResponse } from "msw";
import { describe, expect, it } from "vitest";

import { SearchMode } from "../src";
import { server } from "../mocks/server";
import { SearchMode } from "../src";
import { testClient } from "./test-client";

const SEARCH_URL = "https://apis.quran.foundation/v1/search";
Expand Down Expand Up @@ -68,10 +68,10 @@ describe("Search API", () => {
await testClient.search.search("test", { mode: SearchMode.Quick });

expect(requestUrl).not.toBeNull();
const params = requestUrl?.searchParams;
expect(params?.get("query")).toBe("test");
expect(params?.get("mode")).toBe("quick");
expect(params?.get("size")).toBe("30");
const params = requestUrl!.searchParams;
expect(params.get("query")).toBe("test");
expect(params.get("mode")).toBe("quick");
expect(params.get("size")).toBe("30");
});

it("serializes advanced search params", async () => {
Expand All @@ -92,12 +92,12 @@ describe("Search API", () => {
size: 12,
});

const params = requestUrl?.searchParams;
expect(params?.get("exact_matches_only")).toBe("1");
expect(params?.get("get_text")).toBe("1");
expect(params?.get("highlight")).toBe("0");
expect(params?.get("page")).toBe("2");
expect(params?.get("size")).toBe("12");
const params = requestUrl!.searchParams;
expect(params.get("exact_matches_only")).toBe("1");
expect(params.get("get_text")).toBe("1");
expect(params.get("highlight")).toBe("0");
expect(params.get("page")).toBe("2");
expect(params.get("size")).toBe("12");
});

it("preserves quick search result keys without decamelizing", async () => {
Expand All @@ -115,11 +115,11 @@ describe("Search API", () => {
versesResultsNumber: 9,
});

const params = requestUrl?.searchParams;
expect(params?.get("navigationalResultsNumber")).toBe("7");
expect(params?.get("versesResultsNumber")).toBe("9");
expect(params?.has("navigational_results_number")).toBe(false);
expect(params?.has("verses_results_number")).toBe(false);
const params = requestUrl!.searchParams;
expect(params.get("navigationalResultsNumber")).toBe("7");
expect(params.get("versesResultsNumber")).toBe("9");
expect(params.has("navigational_results_number")).toBe(false);
expect(params.has("verses_results_number")).toBe(false);
});

it("serializes arrays, booleans, and field selections", async () => {
Expand Down Expand Up @@ -151,22 +151,22 @@ describe("Search API", () => {
},
});

const params = requestUrl?.searchParams;
expect(params?.get("translation_ids")).toBe("131,20");
expect(params?.get("filter_translations")).toBe("en,ar");
expect(params?.get("indexes")).toBe("verses,chapters");
expect(params?.get("words")).toBe("true");
const params = requestUrl!.searchParams;
expect(params.get("translation_ids")).toBe("131,20");
expect(params.get("filter_translations")).toBe("en,ar");
expect(params.get("indexes")).toBe("verses,chapters");
expect(params.get("words")).toBe("true");

const fields = params?.get("fields")?.split(",") ?? [];
const fields = params.get("fields")?.split(",") ?? [];
expect(fields).toContain("text_uthmani");
expect(fields).not.toContain("code_v2");

const wordFields = params?.get("word_fields")?.split(",") ?? [];
const wordFields = params.get("word_fields")?.split(",") ?? [];
expect(wordFields).toContain("verse_key");
expect(wordFields).toContain("location");

const translationFields =
params?.get("translation_fields")?.split(",") ?? [];
params.get("translation_fields")?.split(",") ?? [];
expect(translationFields).toContain("resource_name");
expect(translationFields).toContain("language_name");
});
Expand Down