Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Considering a point
pand its four closest pointsp1,p2,p3, andp4, linear interpolation is implemented with the following formula:with the
tibetween 0 and 1 representing the distance betweenpandpi.With integer images, the ImgLib2
NLinearInterpolatorFactorycomputes something like this:This is an issue, because there is a high loss of precision. For example, with an image containing only pixels with value 20, this interpolation can create pixels with values 19 or 21.
This PR provides a custom implementation of the linear interpolation, which computes something like this:
There's still a precision loss, but less than before (and it's unavoidable).