Conversation
petebankhead
approved these changes
Oct 24, 2025
Member
petebankhead
left a comment
There was a problem hiding this comment.
Thanks, that fixes the behavior in #76 for me.
I'm not sure if we should generally be updating the dependencies here, at least not if we intend for this to be reusable in projects that might require older versions (e.g. for compatibility with Java 17).
But since I don't think others are using it at this point, I don't really mind. An advantage of JavaFX 25 is that it could potentially make it possible to remove the dependency on RichTextFX in the future (depending upon how the built-in alternative behaves).
Either way, it would be good to make a release of this soon so that we can integrate it into QuPath and check it's behaving nicely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#76 may be related a JavaFX bug. It happens when:
Double.Infinity.At some point in the
TableViewcode when a column is resized (com.sun.javafx.scene.control.ResizeHelper.distributeLargeDelta()function), the new width of the column is computed from the column max width. When the column max width isDouble.Infinity, the new column width is 0, which creates what is seen in #76.This PR just sets the max width of all columns to something big (2000) but not
Double.Infinity. This should solve the issue.