feat: surpoort GM.xmlHttpRequest upload property#809
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the upload property on GM.xmlHttpRequest by introducing new logic to process upload event handlers, updating the corresponding content script, API processing, background communication, and documentation.
- Update extraction of method names in userscripts entry point
- Incorporate upload handler processing and forwarding in the API and background scripts
- Update README with new API type definitions for upload events
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ext/content-scripts/entry-userscripts.js | Adjusted method extraction for GM. requests |
| src/ext/content-scripts/api.js | Added processing for upload event handlers |
| src/ext/background/main.js | Added upload event listener handling |
| README.md | Updated API docs for upload events |
Comments suppressed due to low confidence (1)
src/ext/content-scripts/api.js:348
- [nitpick] The variable name 'XHRUploadHHandlers' is ambiguous. Consider renaming it to 'XHRUploadHandlers' for improved clarity.
const XHRUploadHHandlers = [
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #807