Skip to content

Emissions#189

Draft
noracato wants to merge 4 commits intomasterfrom
emissions
Draft

Emissions#189
noracato wants to merge 4 commits intomasterfrom
emissions

Conversation

@noracato
Copy link
Copy Markdown
Member

Allows for emission data to be read from a multi-index csv and hashes the data to be imported by etengine.

Still missing:

  • Validation of csv present for all datasets
  • Validation of completness of keys across all dataset (based on what is define for the default dataset)

@noracato noracato requested a review from louispt1 March 31, 2026 15:49
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.99%. Comparing base (923f382) to head (90fb02b).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage   92.78%   92.99%   +0.20%     
==========================================
  Files          91       92       +1     
  Lines        2635     2712      +77     
==========================================
+ Hits         2445     2522      +77     
  Misses        190      190              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@louispt1
Copy link
Copy Markdown
Member

louispt1 commented Apr 1, 2026

Based on the altered csv structure, I've updated the branch slightly - I will explain further noline @noracato but basically the input csvs were split into two separate csvs and the column structure was altered slightly.

Copy link
Copy Markdown
Member Author

noracato commented Apr 2, 2026

This completely changes the design of the module. Let's indeed discuss the redesign, now it became a bit of a mashup of our two things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants