fix: remove Input Monitoring and suppress native permission popups#68
Merged
quiet-node merged 3 commits intomainfrom Apr 8, 2026
Merged
fix: remove Input Monitoring and suppress native permission popups#68quiet-node merged 3 commits intomainfrom
quiet-node merged 3 commits intomainfrom
Conversation
Simplify the onboarding permission flow from 3 steps (Accessibility, Input Monitoring, Screen Recording) to 2 steps (Accessibility, Screen Recording). Input Monitoring checks and IOKit FFI bindings are removed from permissions.rs and PermissionsStep.tsx. The CGEventTap at HID level receives cross-app keyboard events without needing a TCC entry. Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
Gate activator.start() behind is_accessibility_granted() so the HID-level event tap is only created when permission already exists. This prevents macOS from showing the native Accessibility popup during onboarding; the activator starts cleanly on the post-Screen Recording quit+reopen when both permissions are guaranteed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
Owner
Author
Code reviewFound 1 issue:
Two em dashes were introduced on lines 149 and 298: thuki/src/view/onboarding/PermissionsStep.tsx Lines 148 to 150 in c41bf47 thuki/src/view/onboarding/PermissionsStep.tsx Lines 297 to 299 in c41bf47 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
quiet-node
added a commit
that referenced
this pull request
Apr 10, 2026
* refactor: remove Input Monitoring permission requirement from onboarding Simplify the onboarding permission flow from 3 steps (Accessibility, Input Monitoring, Screen Recording) to 2 steps (Accessibility, Screen Recording). Input Monitoring checks and IOKit FFI bindings are removed from permissions.rs and PermissionsStep.tsx. The CGEventTap at HID level receives cross-app keyboard events without needing a TCC entry. Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com> * fix: defer CGEventTap creation until Accessibility is granted Gate activator.start() behind is_accessibility_granted() so the HID-level event tap is only created when permission already exists. This prevents macOS from showing the native Accessibility popup during onboarding; the activator starts cleanly on the post-Screen Recording quit+reopen when both permissions are guaranteed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com> * style: replace em dashes with appropriate punctuation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com> --------- Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
quiet-node
added a commit
that referenced
this pull request
Apr 10, 2026
* refactor: remove Input Monitoring permission requirement from onboarding Simplify the onboarding permission flow from 3 steps (Accessibility, Input Monitoring, Screen Recording) to 2 steps (Accessibility, Screen Recording). Input Monitoring checks and IOKit FFI bindings are removed from permissions.rs and PermissionsStep.tsx. The CGEventTap at HID level receives cross-app keyboard events without needing a TCC entry. Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com> * fix: defer CGEventTap creation until Accessibility is granted Gate activator.start() behind is_accessibility_granted() so the HID-level event tap is only created when permission already exists. This prevents macOS from showing the native Accessibility popup during onboarding; the activator starts cleanly on the post-Screen Recording quit+reopen when both permissions are guaranteed. Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com> * style: replace em dashes with appropriate punctuation Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com> --------- Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
quiet-node
added a commit
that referenced
this pull request
Apr 11, 2026
* refactor: remove Input Monitoring permission requirement from onboarding Simplify the onboarding permission flow from 3 steps (Accessibility, Input Monitoring, Screen Recording) to 2 steps (Accessibility, Screen Recording). Input Monitoring checks and IOKit FFI bindings are removed from permissions.rs and PermissionsStep.tsx. The CGEventTap at HID level receives cross-app keyboard events without needing a TCC entry. Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com> * fix: defer CGEventTap creation until Accessibility is granted Gate activator.start() behind is_accessibility_granted() so the HID-level event tap is only created when permission already exists. This prevents macOS from showing the native Accessibility popup during onboarding; the activator starts cleanly on the post-Screen Recording quit+reopen when both permissions are guaranteed. Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com> * style: replace em dashes with appropriate punctuation Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com> --------- Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
This was referenced Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code