feat(search): add skip_aggregation_finalization to SearchRequest#6145
Open
feat(search): add skip_aggregation_finalization to SearchRequest#6145
Conversation
Add optional bool field to SearchRequest that, when true, skips finalization of aggregation results in root.rs and returns the raw IntermediateAggregationResults bytes instead. This enables callers to handle intermediate results directly for multi-step query merging.
…p_aggregation_finalization
guilload
reviewed
Feb 6, 2026
|
|
||
| // When true, skip finalization of aggregation results and return | ||
| // the raw IntermediateAggregationResults bytes instead. | ||
| optional bool skip_aggregation_finalization = 19; |
Member
There was a problem hiding this comment.
I think you can remove the optional, because the default boolean value is false in protobuf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an optional
skip_aggregation_finalizationfield toSearchRequestthat, when set totrue, skips the finalization of aggregation results inroot.rsand returns the rawIntermediateAggregationResultsbytes instead.This enables callers (e.g., CloudPrem/Pomsky) to handle intermediate aggregation results directly for multi-step query merging.
Changes
search.proto: Addedoptional bool skip_aggregation_finalization = 19toSearchRequest.root.rs: Modifiedfinalize_aggregation_if_any()to return intermediate bytes directly when the flag istrue.rest_handler.rs(search API + elasticsearch API): Setskip_aggregation_finalization: NoneinSearchRequestconstruction.