-
Notifications
You must be signed in to change notification settings - Fork 515
Lambda #6123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
fulmicoton-dd
wants to merge
22
commits into
main
Choose a base branch
from
lambda
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Lambda #6123
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
6bd4931
first stab
fulmicoton-dd 0eb6e28
second stab
fulmicoton-dd b439914
Summary of Changes
fulmicoton-dd 63818cd
File rationalization
fulmicoton-dd 8910340
blop
fulmicoton-dd 984b56c
lambda function validation
fulmicoton-dd fba9519
deployment
fulmicoton-dd 6c5fbf4
rationalizing code
fulmicoton-dd 494a144
blop
fulmicoton-dd 3ac52cd
better config
fulmicoton-dd aa3c16a
better config
fulmicoton-dd bcae2c7
blop
fulmicoton-dd 1e18cd5
blop
fulmicoton-dd aac7014
sever/vclient
fulmicoton-dd 7a4688b
bnlop
fulmicoton-dd 008a121
adding logs
fulmicoton-dd 888e853
blop
fulmicoton-dd 9284059
lambda by default
fulmicoton-dd 748f326
blop
fulmicoton-dd 4cd7cca
deploy versioning, invoke and added metrics.
fulmicoton-dd 93cd5b9
Added unit tests
fulmicoton-dd fd9564f
Moving lambda execution to the leaf.
fulmicoton-dd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| # This workflow creates a new release for a quickwit search aws lambda. | ||
| # The artifact is a zip file containing a binary for ARM 64, | ||
| # ready to be deployed by the deployer. | ||
| # | ||
| # See quickwit-lambda/README.md | ||
| name: Release Lambda binary | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - lambda # This is temporary | ||
| workflow_dispatch: | ||
| inputs: | ||
| version: | ||
| description: 'Version tag (e.g., v0.8.0)' | ||
| required: false | ||
| default: 'dev' | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| build-lambda: | ||
| name: Build Lambda ARM64 | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: write | ||
| actions: write | ||
| steps: | ||
| - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 | ||
|
|
||
| - name: Set version | ||
| run: | | ||
| if [ "${{ github.event.inputs.version }}" = "dev" ]; then | ||
| echo "ASSET_VERSION=dev-$(git rev-parse --short HEAD)" >> $GITHUB_ENV | ||
| else | ||
| echo "ASSET_VERSION=${{ github.event.inputs.version }}" >> $GITHUB_ENV | ||
| fi | ||
|
|
||
| - name: Install rustup | ||
| run: curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain none -y | ||
|
|
||
| - name: Install cross | ||
| run: cargo install cross | ||
|
|
||
| - name: Retrieve and export commit date, hash, and tags | ||
| run: | | ||
| echo "QW_COMMIT_DATE=$(TZ=UTC0 git log -1 --format=%cd --date=format-local:%Y-%m-%dT%H:%M:%SZ)" >> $GITHUB_ENV | ||
| echo "QW_COMMIT_HASH=$(git rev-parse HEAD)" >> $GITHUB_ENV | ||
| echo "QW_COMMIT_TAGS=$(git tag --points-at HEAD | tr '\n' ',')" >> $GITHUB_ENV | ||
|
|
||
| - name: Build Lambda binary | ||
| run: cross build --release --features lambda-release --target aarch64-unknown-linux-gnu -p quickwit-lambda-server --bin quickwit-aws-lambda-leaf-search | ||
| env: | ||
| QW_COMMIT_DATE: ${{ env.QW_COMMIT_DATE }} | ||
| QW_COMMIT_HASH: ${{ env.QW_COMMIT_HASH }} | ||
| QW_COMMIT_TAGS: ${{ env.QW_COMMIT_TAGS }} | ||
| working-directory: ./quickwit | ||
|
|
||
| - name: Create Lambda zip | ||
| run: | | ||
| cd quickwit/target/aarch64-unknown-linux-gnu/release | ||
| cp quickwit-aws-lambda-leaf-search bootstrap | ||
| zip quickwit-aws-lambda-${{ env.ASSET_VERSION }}-aarch64.zip bootstrap | ||
| mv quickwit-aws-lambda-${{ env.ASSET_VERSION }}-aarch64.zip ../../../../ | ||
|
|
||
| - name: Upload to GitHub release | ||
| uses: quickwit-inc/upload-to-github-release@v1 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| file: quickwit-aws-lambda-${{ env.ASSET_VERSION }}-aarch64.zip | ||
| overwrite: true | ||
| draft: true | ||
| tag_name: ${{ env.ASSET_VERSION }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # Quickwit Claude Guidelines | ||
|
|
||
| ## Code Formatting | ||
|
|
||
| Run `make fmt` to check and fix code formatting. This command performs three checks: | ||
|
|
||
| 1. **Rust formatting**: Ensures Rust code is properly formatted (via `cargo fmt`) | ||
| 2. **License headers**: Checks that files are prepended with the correct LICENSE header | ||
| 3. **Log format policy**: Checks that log statements follow our format rules: | ||
| - No trailing punctuation in log messages | ||
| - No uppercase for the first character of log messages | ||
| - See `scripts/check_log_format.sh` for details | ||
|
|
||
| ### Quick Fix | ||
|
|
||
| Use `/fmt` to automatically run format checks and see issues. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium