Add standalone compactors flag and service charts#171
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 93e3a777d0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| {{- if $.Values.compactor.args }} | ||
| args: {{- toYaml $.Values.compactor.args | nindent 10 }} | ||
| {{- else }} | ||
| args: ["run", "--service", "compactor"] |
There was a problem hiding this comment.
When enableStandaloneCompactors=true and users keep the chart default image, this pod still runs quickwit/quickwit:v0.8.2 because image.tag falls back to Chart.appVersion; I checked the v0.8.2 service parser and its accepted --service values are only control-plane|control_plane, indexer, searcher, janitor, and metastore, not compactor. The new compactor Deployment will therefore CrashLoop on this command while the same values disable local indexer merges, so compaction stops unless users know to override image.tag to a compatible build; please bump or guard the default before exposing this flag.
Useful? React with 👍 / 👎.
1 participant
This change is alongside quickwit-oss/quickwit#6461. It adds the enable_standalone_compactor flag. When enabled, it affects three Quickwit services:
As far as the helm chart goes, when false this change is a no-op. When true, it adds the
compactorservice and defines it similarly to other deployments in this chart. It also injects the QW_ENABLE_STANDALONE_COMPACTORS env var to all services as true.