Fix arm64 support, broken Cocoa bindings, and Pinboard API fetching#2
Open
staki1966 wants to merge 1 commit into
Open
Fix arm64 support, broken Cocoa bindings, and Pinboard API fetching#2staki1966 wants to merge 1 commit into
staki1966 wants to merge 1 commit into
Conversation
- Add local xcconfig files so the plugin builds standalone (was referencing /private/tmp/QS/Configuration/) - Build as universal binary (arm64 + x86_64) so the plugin loads on Apple Silicon - Fix header import (was self-importing instead of importing Cocoa/QSCore/QSFoundation) - Fix Localizable.strings file encoding (Mac Roman -> UTF-8) - Replace broken NSObjectController Cocoa bindings with programmatic settings management - Fix Pinboard API fetch: use GET instead of POST, use Authorization header instead of credentials in URL - Post QSCatalogEntryChangedNotification so settings persist across restarts
skurfer
requested changes
May 7, 2026
Member
skurfer
left a comment
skurfer
left a comment
There was a problem hiding this comment.
The code looks OK with just my one question.
We don’t want to copy the configuration files into the plug-in repos though, and I’m thinking all of those buildSettings changes should come out except maybe the PRODUCT_NAME.
| - (void)populateFields { | ||
| NSLog(@"populating: %@/%@", [self.selectedEntry.sourceSettings objectForKey:@"username"], [self.selectedEntry.sourceSettings objectForKey:@"site"]); | ||
| NSMutableDictionary *settings = self.selectedEntry.sourceSettings; | ||
| NSLog(@"QSDelicious: populateFields, settings=%@", settings); |
Member
There was a problem hiding this comment.
Is this going to log any sensitive information?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SocialBookmarks QS plugin was broken for me for a long time, it would always be automatically added to the list of disabled plugins. The principal issues were:
I vibe-coded with AI the following changes and pinboard.in bookmarks now work for me and appear in my QS catalog.
Providing this as-is with no guarantees in the hope others might find it useful. Note that only pinboard.in part was interesting to me so I did not check del.icio.us and ma.gnolia parts at all.
Test plan