Add unit tests check to CI#3102
Closed
pjrobertson wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Turns out qsrelease does run the tests. Ideally this should be split into its own job for clarity, but the way CI currently runs makes this a bit tricky. Closing for now - main thing is to ensure that CI is running tests |
Member
|
I should have some time next week to look at splitting CI into something like build, test, and optionally release phases. Yes the build process is a little funky -- both CLI and from within Xcode 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've just realised that CI wasn't running unit tests. Maybe they can't be run in a headless state... let's see