Remove non-standard InternalError exception type#1517
Closed
saghul wants to merge 1 commit into
Closed
Conversation
InternalError is a Mozilla extension that V8 and JavaScriptCore do not implement. Remove it from the engine and map its existing uses to the appropriate standard error types: RangeError for resource-exhaustion conditions (out of memory, string too long, regexp OOM, unreasonable atom count) and plain Error for engine-invariant assertion failures (invalid opcodes, stack inconsistency, corrupted bytecode, etc.). Fixes: #1516
saghul
force-pushed
the
remove-internal-error
branch
from
d36b697 to
b12c559
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InternalError is a Mozilla extension that V8 and JavaScriptCore do not
implement. Remove it from the engine and map its existing uses to the
appropriate standard error types: RangeError for resource-exhaustion
conditions (out of memory, string too long, regexp OOM, unreasonable
atom count) and plain Error for engine-invariant assertion failures
(invalid opcodes, stack inconsistency, corrupted bytecode, etc.).
Fixes: #1516