Skip to content

Walk the cause chain when dumping uncaught errors #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saghul merged 2 commits into from
May 25, 2026
+31 −12
Merged

Walk the cause chain when dumping uncaught errors #1509

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
654c569
Walk the cause chain when dumping uncaught errors
saghul May 22, 2026
fc3e1ea
fixup!
saghul May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 31 additions & 12 deletions quickjs-libc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4720,22 +4720,41 @@ static void js_dump_obj(JSContext *ctx, FILE *f, JSValueConst val)
}
}

#define JS_DUMP_ERROR_MAX_CAUSE_DEPTH 10

static void js_std_dump_error1(JSContext *ctx, JSValueConst exception_val)
{
JSValue val;
JSValue val, current;
bool is_error;

is_error = JS_IsError(exception_val);
js_dump_obj(ctx, stderr, exception_val);
if (is_error) {
val = JS_GetPropertyStr(ctx, exception_val, "stack");
} else {
js_std_cmd(/*ErrorBackTrace*/2, ctx, &val);
}
if (!JS_IsUndefined(val)) {
js_dump_obj(ctx, stderr, val);
JS_FreeValue(ctx, val);
int depth;

current = JS_DupValue(ctx, exception_val);
for (depth = 0; ; depth++) {
is_error = JS_IsError(current);
js_dump_obj(ctx, stderr, current);
if (is_error) {
val = JS_GetPropertyStr(ctx, current, "stack");
} else if (depth == 0) {
js_std_cmd(/*ErrorBackTrace*/2, ctx, &val);
} else {
val = JS_UNDEFINED;
}
if (!JS_IsUndefined(val)) {
js_dump_obj(ctx, stderr, val);
JS_FreeValue(ctx, val);
}
if (!is_error || depth >= JS_DUMP_ERROR_MAX_CAUSE_DEPTH)
break;
val = JS_GetPropertyStr(ctx, current, "cause");
if (JS_IsUndefined(val)) {
JS_FreeValue(ctx, val);
break;
}
fputs("Caused by: ", stderr);
JS_FreeValue(ctx, current);
current = val;
}
JS_FreeValue(ctx, current);
}

void js_std_dump_error(JSContext *ctx)
Expand Down
Loading