chore: migrate tests to JUnit 5, remove junit-vintage-engine#10
Merged
Conversation
Copilot created this pull request from a session on behalf of
chrjohn
June 6, 2026 20:00
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
junit-vintage-enginewas declared only to run JUnit 4 tests via the JUnit Platform — the direct JUnit 4 APIs were used but undeclared (transitive). Migrating to JUnit 5 removes this indirection and cleans up the dependency graph.Changes
pom.xmlorg.junit.vintage:junit-vintage-enginewithorg.junit.jupiter:junit-jupiter(aggregator: API + params + engine)Test classes
@Rule TemporaryFolder→@TempDir File(JUnit 5 built-in temp dir injection)@Before→@BeforeEachorg.junit.Assert.*→org.junit.jupiter.api.Assertions.*assertTrue("msg", condition)→assertTrue(condition, "msg")— argument order is reversed in JUnit 5tempFolder.newFolder("x")/tempFolder.getRoot()→new File(tempFolder, "x")with assertedmkdir()