build: use pkg-config for qmi-framework discovery#11
Merged
Conversation
Replace the hardcoded qmi path handling with pkg-config as the
primary mechanism for locating qmi-framework.
The qmi-framework.pc file exposes Cflags as -I${includedir}, which
resolves to /usr/include and can be filtered by pkgconf as a default
system include path. Derive the required include path from the
pkg-config prefix as ${prefix}/include/qmi_framework, while keeping
--with-qmi-prefix as a fallback when pkg-config cannot find the\npackage.
Also update the automake variables to consume substituted QMI flags,
and stop installing time-daemon.service through make install so Debian
packaging can handle the service file separately.
Signed-off-by: Jairaj Solanki <jsolanki@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the hardcoded qmi path handling with pkg-config as the primary mechanism for locating qmi-framework.
The qmi-framework.pc file exposes Cflags as -I${includedir}, which resolves to /usr/include and can be filtered by pkgconf as a default system include path. Derive the required include path from the pkg-config prefix as ${prefix}/include/qmi_framework, while keeping --with-qmi-prefix as a fallback when pkg-config cannot find the\npackage.
Also update the automake variables to consume substituted QMI flags, and stop installing time-daemon.service through make install so Debian packaging can handle the service file separately.