This repository was archived by the owner on Jan 7, 2025. It is now read-only.
[On hold] Add digit recognition example#64
Draft
corneliusboehm wants to merge 19 commits intomasterfrom
Draft
Conversation
# Conflicts: # realtimenet/display.py
# Conflicts: # sense/display.py # sense/downstream_tasks/digit_recognition/__init__.py
Contributor
|
I'm pretty sure this is unrelated to your example, but in a fresh installation of the repo and environment, I can't get the demo to work. It prints two lines, does not open a window, does not show an error, and simply terminates. Have you seen this before? |
Contributor
Author
|
Don't think I have seen this 😕 Do any of the other demos work? |
floriandotpy
reviewed
Jan 7, 2021
Contributor
floriandotpy
left a comment
There was a problem hiding this comment.
Code looking good. I left minor comments.
I've tested it now, but unfortunately, it didn't work really well for me. I feel like our old airdigits demo was way more reliable and I also didn't have to be so careful with the timing of my motion.
https://drive.google.com/file/d/1kZvOM1iCSyM3fq3alcK8jcNK5Ya8xbOP/view?usp=sharing
floriandotpy
reviewed
Jan 7, 2021
Co-authored-by: Florian Letsch <florianletsch@users.noreply.github.com>
Co-authored-by: Florian Letsch <florianletsch@users.noreply.github.com>
… into feature/digit-recognition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final layer of both backbone networks was trained to recognize digits drawn in the air and some display logic is added.
General updates:
font_scaleandthicknessinput_textruntime_errorhandling incontroller.py, because it was not showing the relevant exception, but only thatruntime_errorwas used before declarationHere's a perfect run where all digits are recognized (even though it doesn't always work): https://drive.google.com/file/d/1pEM0a2OYGxPvuqC9gvft8RQKb9iVdtkY/view?usp=sharing
Please try this out yourself and let me know if it's good enough to be a visible example in the README.