Skip to content

nit(transforms): Fix ONNX export reuse and expand causal LM subfunction compile coverage#873

Open
vbaddi wants to merge 4 commits intoquic:mainfrom
vbaddi:dev/fix_clip_split_transforms
Open

nit(transforms): Fix ONNX export reuse and expand causal LM subfunction compile coverage#873
vbaddi wants to merge 4 commits intoquic:mainfrom
vbaddi:dev/fix_clip_split_transforms

Conversation

@vbaddi
Copy link
Contributor

@vbaddi vbaddi commented Mar 18, 2026

This PR tightens the ONNX export path in modeling_qeff and updates quickcheck coverage.

Changes:

  • Validate cached ONNX before reuse and re-export if the cached file is invalid.
  • Use instance-level transform names for hashing/metadata so export cache reflects the
    active transform set.
  • Only pass onnx_base_dir when ONNX transforms actually need external tensor data
    (FP16ClipTransform / SplitTensorsTransform), avoiding unnecessary tensor
    materialization in the default path.
  • Keep the lightweight onnx_transforms guard so external data is only loaded when a
    base dir is provided.

Tests:

  • Removed the use_dynamo quickcheck case.
  • Added .compile(..., use_onnx_subfunctions=True) mocked compile-path coverage for all
    causal-LM quickcheck models.
  • Full quickcheck validation passed:
    • python -m pytest -q tests/test_model_quickcheck.py -n auto

Signed-off-by: vbaddi <vbaddi@qti.qualcomm.com>
Signed-off-by: vbaddi <vbaddi@qti.qualcomm.com>
vbaddi added 2 commits March 19, 2026 07:55
…form warning

Signed-off-by: vbaddi <vbaddi@qti.qualcomm.com>
Adds a dedicated GitHub Actions workflow to run the quickcheck suite on every PR for faster regression visibility.

  - New workflow: quickcheck.yml
  - Triggers:
      - pull_request
      - workflow_dispatch (manual run)
  - Job config:
      - ubuntu-latest
      - Python 3.10 via actions/setup-python@v5
      - pip caching enabled
      - timeout-minutes: 90
      - concurrency cancellation enabled per PR/
        ref

  - Installs required deps:
      - python -m pip install -e .[test]
      - python -m pip install pytest-xdist
  - Runs:
      - python -m pytest -q tests/test_model_quickcheck.py -n auto

Signed-off-by: vbaddi <vbaddi@qti.qualcomm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants