-
Notifications
You must be signed in to change notification settings - Fork 61
Extend on-device sampling support for dual QPC VLMs #597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
quic-xiyushi
wants to merge
14
commits into
quic:main
Choose a base branch
from
quic-xiyushi:on-device-sampling-vlm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+346
−167
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
409da24
Extend on-device sampling support for dual QPC VLMs
quic-xiyushi e06e175
Fix random_numbers shape
quic-xiyushi 3e242ce
Update example with new random sampling logic
quic-xiyushi 1a01d57
Update to align with recent VLM CB changes
quic-xiyushi 30d6061
Update tests with new random sampling logic
d02d04d
Merge remote-tracking branch 'origin/main' into HEAD
quic-xiyushi 7cf106e
Refactor
quic-xiyushi 45aed11
Add unit tests
quic-xiyushi 6273ab5
Clean up
quic-xiyushi ef9ae14
Merge remote-tracking branch 'origin/main' into HEAD
quic-xiyushi 3789d5a
Update test_sampler.py
quic-xiyushi 5e2afb7
Fix hash for VLM's language decoder to include qaic_config
quic-xiyushi df06617
Merge remote-tracking branch 'origin/main' into HEAD
quic-xiyushi 10990a9
Fix bug in getting vocab_size and missing ccl in forward
quic-xiyushi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean we are enabling sampling only for intern model?
Will other VLMs also be supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other VLMs are also supposed to be supported. But currently only InternVL and Qwen VL 2.5 have been tested.