Skip to content

Remove noexcept from line_sender::protocol_version() and line_sender::new_buffer() #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arghness wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Remove noexcept from line_sender::protocol_version() and line_sender::new_buffer() #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/questdb/ingress/line_sender.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1110,14 +1110,14 @@ class line_sender
/**
* Get the current protocol version used by the sender.
*/
questdb::ingress::protocol_version protocol_version() const noexcept
questdb::ingress::protocol_version protocol_version() const
{
ensure_impl();
return static_cast<enum protocol_version>(
static_cast<int>(::line_sender_get_protocol_version(_impl)));
}

line_sender_buffer new_buffer(size_t init_buf_size = 64 * 1024) noexcept
line_sender_buffer new_buffer(size_t init_buf_size = 64 * 1024)
{
ensure_impl();
return line_sender_buffer{
Expand Down