Skip to content

docs: fix broken links & rendering#267

Merged
leahaeusel merged 4 commits intoqueens-py:mainfrom
leahaeusel:fix-documentation-links
Jan 30, 2026
Merged

docs: fix broken links & rendering#267
leahaeusel merged 4 commits intoqueens-py:mainfrom
leahaeusel:fix-documentation-links

Conversation

@leahaeusel
Copy link
Copy Markdown
Member

@leahaeusel leahaeusel commented Dec 29, 2025

Description and Context:
What and Why?

This PR fixes some broken links in our documentation that were introduced (by me 🙈 ) in #263. To avoid this in the future, I have switched to relative links to documentation websites and added checks for wrong links by activating nitpicky and failing on warnings (sphinx-build -W).

To resolve a few legitimate warnings, I had to add first-level headers to our FAQ pages and adjust a docstring indentation in mixture_model.py.

While looking through the built documentation, I also noticed that the first tutorial had lots of lists and equations that weren't rendered correctly. This should also be fixed now.

Related Issues and Pull Requests

Interested Parties

Note: More information on the merge request procedure in QUEENS can be found in the Submit a pull request section in the CONTRIBUTING.md file.

@leahaeusel leahaeusel force-pushed the fix-documentation-links branch 2 times, most recently from 54fb8ea to 7050a00 Compare December 30, 2025 09:26
@leahaeusel leahaeusel changed the title docs: fix broken links docs: fix broken links & rendering Dec 30, 2025
@leahaeusel leahaeusel force-pushed the fix-documentation-links branch from 7050a00 to 138a045 Compare December 30, 2025 09:43
@leahaeusel leahaeusel marked this pull request as ready for review December 30, 2025 09:44
Copy link
Copy Markdown
Contributor

@danielwolff1 danielwolff1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the broken links and improving the rendering of the documentation, looks good to me! 😊

Comment thread tutorials/1_grid_iterator_rosenbrock.ipynb Outdated
Comment thread doc/README.md
leahaeusel and others added 2 commits January 12, 2026 16:56
Co-authored-by: Daniel Wolff <39346676+danielwolff1@users.noreply.github.com>
@leahaeusel leahaeusel force-pushed the fix-documentation-links branch from 53a8b99 to 0426578 Compare January 12, 2026 15:57
@danielwolff1
Copy link
Copy Markdown
Contributor

danielwolff1 commented Jan 12, 2026

Now that I was able to build the documentation I noticed three additional small things:

  • CONTRIBUTING.md:#L82: I suppose the link needs to be changed to src/queens/utils/path.py#L23
  • CONTRIBUTING.md:#L83: And same here src/queens/utils/logger_settings.py#L239
  • tests/README.md:#L13: this link unfortunately does neither work in the local nor in the online documentation, try the link on this page. However, it works when viewing the README.md in the directory, see here

However since you mostly wanted to fix the broken links introduced by #263, I guess this can also be deferred to another PR 😊

@leahaeusel
Copy link
Copy Markdown
Member Author

leahaeusel commented Jan 14, 2026

However since you mostly wanted to fix the broken links introduced by #263, I guess this can also be deferred to another PR 😊

I would say this falls right into this PR's topic of fixing broken links 😉 Really nice catches, thank you for checking the links so thoroughly!

@danielwolff1
Copy link
Copy Markdown
Contributor

Looks good to me now, thanks for adapting this! 🎉

I guess now you just need someone to approve this 😁

@leahaeusel leahaeusel requested a review from gilrrei January 16, 2026 10:43
Copy link
Copy Markdown
Member

@sbrandstaeter sbrandstaeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @danielwolff1 I trust your review.

@leahaeusel leahaeusel merged commit d0b512a into queens-py:main Jan 30, 2026
3 checks passed
@leahaeusel leahaeusel deleted the fix-documentation-links branch January 30, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants