Skip to content

update TokenRaffle in QRaffle SC#898

Open
double-k-3033 wants to merge 22 commits into
qubic:developfrom
double-k-3033:feature/qraffle
Open

update TokenRaffle in QRaffle SC#898
double-k-3033 wants to merge 22 commits into
qubic:developfrom
double-k-3033:feature/qraffle

Conversation

@double-k-3033
Copy link
Copy Markdown
Contributor

@double-k-3033 double-k-3033 commented May 26, 2026

  • Remove statement that check the qraffle DAO members in TokenRaffle. So everyone can participate in TokenRaffle.
  • Remove statement that check the internal token and share - qraffle and qxmr.
  • Remove statement that check the amount of asset.

Comment thread test/contract_qportal.cpp Outdated
@Franziska-Mueller
Copy link
Copy Markdown
Collaborator

can you please explain the reasoning for removing these checks? they were only very recently added in #853

@double-k-3033
Copy link
Copy Markdown
Contributor Author

can you please explain the reasoning for removing these checks? they were only very recently added in #853

Users are currently experiencing inconvenience because only DAO members can join the token raffle, and opinions have been raised suggesting that internal tokens should also be used. Therefore, these items have been removed.

Copy link
Copy Markdown
Collaborator

@Franziska-Mueller Franziska-Mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved from a code point of view. however, this logic change to existing procedures requires approval from the computors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants