IPO QThirtyFour#684
Conversation
# Conflicts: # src/Qubic.vcxproj # src/contract_core/contract_def.h
…reserve and don’t consume reseed budget with tier top-ups on k4 rounds - test/contract_qtf.cpp: expose private/protected internals for unit tests, add exact-match k2/k3 ticket generators (unique), fund jackpot balance in k4 test, and force FR off in baseline k2/k3 revenue-split test
# Conflicts: # src/contract_core/contract_def.h # src/contracts/RandomLottery.h # test/test.vcxproj # test/test.vcxproj.filters
…eserve top-ups; correct schedule bitmask in specx
Auto-update QTF index in QRP Adds cleanup for allowedSmartContracts in QRP
Franziska-Mueller
left a comment
There was a problem hiding this comment.
Please merge develop and fix the contract indices in contract_def.h.
You can decide in which epoch the proposals for QDuel and QThirtyFour/QReservePool should happen and adapt the indices accordingly.
# Conflicts: # src/contract_core/contract_def.h
# Conflicts: # src/contract_core/contract_def.h
# Conflicts: # src/contract_core/contract_def.h
# Conflicts: # src/contract_core/contract_def.h
# Conflicts: # src/Qubic.vcxproj
# Conflicts: # src/contract_core/contract_def.h
|
@N-010 Is everything working correctly? The following global constants may not be initialized correctly in the UEFI build: At least, these lines trigger the following warning: https://learn.microsoft.com/en-us/cpp/error-messages/tool-errors/linker-tools-warning-lnk4210?view=msvc-170 We don't have the VCRuntime library and I have experienced at other occasions that the init does not happen in this case. I wouldn't be surprised if these are NULL_ID in the UEFI build. Please remove these constants from the global scope in a new PR, so we get rid of this warning again. @Franziska-Mueller I think we should extend the contact checking tool to only allow constexpr in global scope and disallow const in order to prevent this warning and potential errors. |
Issue desciption: #684 (comment)
Proposal:
QTF
QRP