fix: correct contract index validation and wire up in Send page#1
Open
alez04 wants to merge 2 commits into
Open
fix: correct contract index validation and wire up in Send page#1alez04 wants to merge 2 commits into
alez04 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Contract index validation in
ValidateDestination()was capping out at 23, but mainnet already has 27 deployed contracts. The lower bound was also incorrect—indices start at 1, not 0.Additionally, during this audit it was discovered that
ValidateDestination()wasn't actually being utilized for theSendfeature. The Send page had its own hardcoded length check (.Length != 60) that prevented contract indices from being entered, andAllowContractIndexwas disabled on the input component.Fix
ScAuctions.razorand protocol specifications.AllowContractIndex="true".ResolveIdentityhelper to cleanly convert the input string (whether a 60-character address or a short contract index) into a validQubicIdentitybefore signing.Send.razorto use the correct validation and resolution paths.