Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the @bloqify decorator, which provides a function-based syntax for constructing CompositeBloq objects. To support this, BloqBuilder and CompositeBloq have been updated to include a bloq_key for better tracking and debugging. Additionally, the finalize method now supports a 'loose' mode that automatically converts missing THRU registers to LEFT registers. Review feedback highlights a potential performance issue where bloqified functions are re-traced on every call and suggests preserving exception context when re-raising BloqError to aid debugging.
| f = self._prep_qstackframe(self._bound_kvs(*args, **kwargs)) | ||
| return bb.add( |
There was a problem hiding this comment.
The current implementation of __call__ triggers a full trace of the bloqified function every time it is called as a sub-bloq. This can lead to significant performance overhead, especially when bloqified functions are used within loops or nested deep in a hierarchy. Consider caching the resulting CompositeBloq based on the classical arguments provided to the function to avoid redundant tracing.
There was a problem hiding this comment.
This is the fundamental trade-off of using the tracing approach. We can't cache based on arguments, as the behavior is liable to change based on things like the data type "hidden" in the QVar objects (unlike the traditional qlt.Bloq which demands the developer list the classical parameters)
1 participant
"tracing style" bloq construction. This is the basics. More syntactic sugar, docs, and examples to follow.