Add unit test to cover previously-uncovered BKSF transform cases#1328
Closed
mhucka wants to merge 4 commits into
Closed
Add unit test to cover previously-uncovered BKSF transform cases#1328mhucka wants to merge 4 commits into
mhucka wants to merge 4 commits into
Conversation
mhucka
changed the title
bksf_test.py to cover previously-uncovered cases
Collaborator
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes # pragma: no cover comments from bksf.py and adds a new test case test_bravyi_kitaev_fast_interaction_op_coverage to cover those previously skipped code paths. The feedback recommends replacing the standard assert statement in the new test with self.assertIsNotNone(qubit_op) to ensure the test is always executed, even when Python is run with optimization flags.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
mhucka
changed the title
bksf_test.py to cover previously-uncovered cases
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test to resolve a missing test coverage, and removes two
pragma: no covercomments in bksf.py.