Fix RDM basis set rotation#1325
Open
arettig wants to merge 1 commit into
Open
Conversation
RDM basis set rotations now use the conjugate of the rotation matrices. Added new tests that will fail if the old convention is used.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements the rotate_basis method for the InteractionRDM class, which rotates its orbital basis using the conjugate of the provided rotation matrix. Additionally, it introduces unit tests to verify the basis rotation functionality and to confirm the invariance of expectation values under basis rotations. No review comments were provided, so there is no feedback to address.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #603, where RDM basis set rotations incorrectly used the same rotation matrices as operators instead of the conjugate.
The
rotate_basis()method is now overridden ininteraction_rdm.py.Added new tests that check the
rotate_basis()method and will fail if old convention is used.