Fix vendor-related issue when using termbox types#1
Open
mocheryl wants to merge 1 commit intoquantum:masterfrom
Open
Fix vendor-related issue when using termbox types#1mocheryl wants to merge 1 commit intoquantum:masterfrom
mocheryl wants to merge 1 commit intoquantum:masterfrom
Conversation
Consider the following code:
package main
import (
"github.com/nsf/termbox-go"
g "github.com/quantum/gonsole"
)
func main() {
app := g.NewApp()
app.CloseKey = termbox.KeyCtrlQ
app.Run()
}
It will not compile outside of gonsole directory because the termbox
type used here does not match the one used in the vendor directory.
According to some discussions I found, such behavior should be
restricted to main applications only. Libraries in this case should
either un-vendor the package or wrap all the exported types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider the following code:
It will not compile outside of gonsole directory because the termbox
type used here does not match the one used in the vendor directory.
According to some discussions I found, such behavior should be
restricted to main applications only. Libraries in this case should
either un-vendor the package or wrap all the exported types.